fix: use go.mod protobuf version for generation #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove explicit version from shell script and use go.mod
elastic-observability-automation
bot
added
the
safe-to-test
rubvs
approved these changes
Nov 7, 2024
Merged
simitt
reviewed
Nov 8, 2024
| @@ -16,7 +16,7 @@ | |||
| // under the License. | |||
|
|
|||
| // Code generated by protoc-gen-go-vtproto. DO NOT EDIT. | |||
| // protoc-gen-go-vtproto version: v0.6.0 | |||
| // protoc-gen-go-vtproto version: v0.6.1-0.20240319094008-0393e58bdf10 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑💻 What changed
remove explicit version from shell script and use go.mod
❓ Why was this changed
go.mod version and shell version needs to be kept in sync
✅ How to test
run
make generate-modelpb