Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error.id to jaeger errors #272

Merged
merged 2 commits into from
May 7, 2024

Merge branch 'main' into fix/jaeger-error-id

283f140
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: add error.id to jaeger errors #272

Merge branch 'main' into fix/jaeger-error-id
283f140
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded May 7, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 283f140

Base sha: 337a5ee

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 26849 2% 26536.2 1% ~ (p=0.190 n=4+5)
Encode/format=json-2 14483.4 4% 13928.8 1% ~ (p=0.063 n=5+4)
Encode/format=vtproto 6221 1% 6234.8 0% ~ (p=0.690 n=5+5)
Encode/format=vtproto-2 3517.4 4% 3443.6 2% ~ (p=0.421 n=5+5)
Decode/format=json 129932 1% 130503 4% ~ (p=1.000 n=5+5)
Decode/format=json-2 64466.4 6% 62083.2 1% ~ (p=0.063 n=5+4)
Decode/format=vtproto 21739.8 2% 22225.4 1% +2.23% (p=0.032 n=5+5)
Decode/format=vtproto-2 13508 15% 13413.2 3% ~ (p=0.222 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7752 0% 7752 0% ~ (all equal)
Encode/format=json-2 7753 0% 7753 0% ~ (all equal)
Encode/format=vtproto 3200 0% 3200 0% ~ (all equal)
Encode/format=vtproto-2 3200 0% 3200 0% ~ (all equal)
Decode/format=json 14504 0% 14504 0% ~ (all equal)
Decode/format=json-2 14504 0% 14504 0% ~ (all equal)
Decode/format=vtproto 12976 0% 12976 0% ~ (all equal)
Decode/format=vtproto-2 13013.8 0% 13014.4 0% ~ (p=0.429 n=5+5)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 30 0% 30 0% ~ (all equal)
Encode/format=json-2 30 0% 30 0% ~ (all equal)
Encode/format=vtproto 5 0% 5 0% ~ (all equal)
Encode/format=vtproto-2 5 0% 5 0% ~ (all equal)
Decode/format=json 397 0% 397 0% ~ (all equal)
Decode/format=json-2 397 0% 397 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 284.12 5% 305.9 12% ~ (p=0.095 n=5+5)
NDStreamDecoder-2 158.6 2% 173.52 5% +9.41% (p=0.008 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 14018.4 6% 15287 6% +9.05% (p=0.032 n=5+5)
APMEventToJSON/to-json-2 12577.6 1% 12800 1% +1.77% (p=0.008 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2472 0% 2472 0% ~ (all equal)
APMEventToJSON/to-json-2 2472 0% 2472 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 37 0% 37 0% ~ (all equal)
APMEventToJSON/to-json-2 37 0% 37 0% ~ (all equal)
View more details on GitHub Actions