Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update protobuf models to use uint64 for timestamps #136

Merged
merged 5 commits into from
Aug 9, 2023
Merged

feat: update protobuf models to use uint64 for timestamps #136

merged 5 commits into from
Aug 9, 2023

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 7, 2023

Smaller scope of #134

Update protobuf models to store timestamp as uint64.

We can discuss modeljson and input models later, this should be enough to update the aggregation code.

@kruskall kruskall requested a review from a team as a code owner August 7, 2023 08:22
axw
axw approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one issue

model/modelpb/timestamp.go Outdated Show resolved Hide resolved
@kruskall kruskall enabled auto-merge (squash) August 9, 2023 07:56
@kruskall kruskall merged commit a636758 into elastic:main Aug 9, 2023
@kruskall kruskall deleted the feat/pb-uint-timestamp branch August 9, 2023 08:04
@kruskall kruskall mentioned this pull request Aug 9, 2023
Closed
@axw axw mentioned this pull request Aug 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruskall @axw