Skip to content

Commit

Permalink
Add TODOs to confirm if metadata should be updated
Browse files Browse the repository at this point in the history
  • Loading branch information
ericywl committed Jan 24, 2025
1 parent f86e95f commit 256abb5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions input/otlp/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ func translateResourceMetadata(resource pcommon.Resource, out *modelpb.APMEvent)
}
out.User.Name = truncate(v.Str())

// TODO(eric): Check if `user.*` fields are considered resource metadata?

// os.*
case semconv.AttributeOSType:
if out.Host == nil {
Expand Down Expand Up @@ -471,6 +473,9 @@ func translateScopeMetadata(scope pcommon.InstrumentationScope, out *modelpb.APM
}
out.DataStream.Namespace = sanitizeDataStreamNamespace(v.Str())
}

// TODO(eric): Check if `user.*` fields are considered scope metadata?

return true
})

Expand Down

0 comments on commit 256abb5

Please sign in to comment.