test: update e2e-testing/sam-nodejs deps #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes deps not being used by the 'sam-testing-nodejs' package used in e2e-testing. It bumps elastic-apm-node to its current major version. This also makes some attempts to get e2e-testing working again, but ultimately I did not get far. e2e-testing looks to not have been updated for changes in how the apm-lambda-extension is now built. Obsoletes: elastic#624
|
Added @dmathieu because I see you had the latest commit to e2e_test.go. I could not get anything passing there. Help appreciated... or if e2e-testing isn't being used, then ... |
kruskall
approved these changes
Mar 13, 2025
rockdaboot
approved these changes
Mar 14, 2025
dmathieu
approved these changes
Mar 14, 2025
|
Someone please merge. I don't have permissions on this repo. |
|
Thank you, @trentm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes deps not being used by the 'sam-testing-nodejs' package
used in e2e-testing. It bumps elastic-apm-node to its current major
version.
This also makes some attempts to get e2e-testing working again, but
ultimately I did not get far. e2e-testing looks to not have been
updated for changes in how the apm-lambda-extension is now built.
Obsoletes: #624