ci: support provenance #1489
Open
ci: support provenance #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,7 +151,7 @@ | |||
| "karma-sourcemap-loader": "^0.3.7", | |||
| "karma-spec-reporter": "^0.0.31", | |||
| "karma-webpack": "^5.0.0", | |||
| "lerna": "^4.0.0", | |||
| "lerna": "^6.6.2", | |||
There was a problem hiding this comment.
Hopefully this upgrade doesn't cause lots of headache 🚨 Sorry about that.
There was a problem hiding this comment.
Yep, I tried to use the oldest with support for provenance... and I don't know if we are ready to support this
reakaleek
reviewed
May 6, 2024
reakaleek
reviewed
May 6, 2024
Co-authored-by: Jan Calanog <[email protected]>
reakaleek
reviewed
May 6, 2024
| @@ -109,8 +113,14 @@ jobs: | |||
| name: 'Prepare CDN release' | |||
| run: echo "versions=$(npm run --silent ci:prepare-release)" >> ${GITHUB_OUTPUT} | |||
|
|
|||
| - name: generate build provenance | |||
| if: ${{ always() && hashFiles('packages/rum/dist/bundles/*.js') | |||
There was a problem hiding this comment.
Sorry, there were missing }} in the suggestion.
Suggested change
| if: ${{ always() && hashFiles('packages/rum/dist/bundles/*.js') | |
| if: ${{ always() && hashFiles('packages/rum/dist/bundles/*.js') }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
dry-run=truepackages/rum/dist/bundles/*.jsProvenance is fully supported with GH actions and NPM, see https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions
Further details
See lerna/lerna#3657
Lerna breaking changes for 5 in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#500-2022-05-24 and for 6 in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#600-2022-10-12
Related issues
Closes #ISSUE
Test
See this build but it's not doing much since no changes are found in lerna :/