Skip to content

Commit

Permalink
fix: split artifacts upload and use nodejs 14 for testing
Browse files Browse the repository at this point in the history
Signed-off-by: apmmachine <[email protected]>
  • Loading branch information
apmmachine committed Jan 5, 2024
1 parent 1f128ca commit 59a06c0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .ci/scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ APM_SERVER_PORT=${APM_SERVER_PORT:-"8200"}
APM_SERVER_URL=${APM_SERVER_URL:-"http://apm-server:8200"}
KIBANA_URL=${KIBANA_URL:-"http://kibana:5601"}

# The migration of this to Node.js 18 will wait. To update playwright (and browsers)
# to make it work in Node.js 18 and latest version in ubuntu (or another OS)
# will require us to invest a certain amount of time
NODEJS_VERSION=14

# As long as there are issues with the ssl lets use 6.1.3
# see https://github.com/docker/docker-py/issues/3194
pip3 uninstall docker
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ runs:
if: success() || failure()
uses: actions/upload-artifact@v4
with:
name: test-results
name: test-results-${{ github.run_id }}-${{ github.run_attempt }}
path: |
packages/**/reports/TESTS-*.xml
8 changes: 4 additions & 4 deletions .github/workflows/test-reporter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- uses: elastic/apm-pipeline-library/.github/actions/test-report@current
with:
artifact: test-results # artifact name
name: JUnit Tests # Name of the check run which will be created
path: "**/*.xml" # Path to test results (inside artifact .zip)
reporter: java-junit # Format of test results
artifact: test-results-${{ github.run_id }}-${{ github.run_attempt }}-(.*) # artifact name
name: JUnit Tests # Name of the check run which will be created
path: "**/*.xml" # Path to test results (inside artifact .zip)
reporter: java-junit # Format of test results

0 comments on commit 59a06c0

Please sign in to comment.