test: modernize our mssql/server Docker image usage #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move to the latest CU (cumulative update) of SQLServer 2022 (which involves updating the healthcheck for internal changes) - use MSSQL_SA_PASSWORD rather than the long since deprecated SA_PASSWORD Refs: #4147
david-luna
approved these changes
Jul 29, 2024
trentm
added a commit
to elastic/elastic-otel-node
that referenced
this pull request
Aug 1, 2024
First, add a Makefile for those with 'make' in their blood: make all test Also fix mssql image usage after breakage in the latest release, copying what was done in elastic/apm-agent-nodejs#4150
trentm
added a commit
to elastic/elastic-otel-node
that referenced
this pull request
Aug 1, 2024
#306) First, add a Makefile for those with 'make' in their blood: `make all lint test` Also fix mssql image usage after breakage in the latest release, copying what was done in elastic/apm-agent-nodejs#4150
trentm
added a commit
that referenced
this pull request
Aug 1, 2024
- move to the latest CU (cumulative update) of SQLServer 2022 (which involves updating the healthcheck for internal changes) - use MSSQL_SA_PASSWORD rather than the long since deprecated SA_PASSWORD Refs: #4147
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
- move to the latest CU (cumulative update) of SQLServer 2022 (which involves updating the healthcheck for internal changes) - use MSSQL_SA_PASSWORD rather than the long since deprecated SA_PASSWORD Refs: elastic#4147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which involves updating the healthcheck for internal changes)
Refs: #4147
A working healthcheck for the latest mssql/server image was provided by:
microsoft/mssql-docker#892 (comment)