fix: handle invalid chars in host header #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
reviewed
Mar 19, 2024
CHANGELOG.asciidoc
Outdated
| @@ -46,6 +46,8 @@ See the <<upgrade-to-v4>> guide. | |||
| [float] | |||
| ===== Bug fixes | |||
|
|
|||
| * Fix path resolution for requests that contain invalid characters in its | |||
There was a problem hiding this comment.
This should be added to a new ==== Unreleased section. See template for the new section at the top of the CHANGELOG file.
| const req = createRequest( | ||
| 'https://test.com/foo/bar?query=value#hash', | ||
| // eslint-disable-next-line prettier/prettier, no-useless-escape | ||
| 'invalid\host\name', |
There was a problem hiding this comment.
Does that actually throw in the try/catch?
> new URL('http://invalid\\host\\name')
URL {
href: 'http://invalid/host/name',
origin: 'http://invalid',
protocol: 'http:',
username: '',
password: '',
host: 'invalid',
hostname: 'invalid',
port: '',
pathname: '/host/name',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
> new URL('http://invalid\host\name')
URL {
href: 'http://invalidhostame/',
origin: 'http://invalidhostame',
protocol: 'http:',
username: '',
password: '',
host: 'invalidhostame',
hostname: 'invalidhostame',
port: '',
pathname: '/',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
This works, er fails :)
> new URL('http://bad[hostname')
Uncaught TypeError [ERR_INVALID_URL]: Invalid URL
at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)
at new NodeError (node:internal/errors:405:5)
at new URL (node:internal/url:637:13) {
input: 'http://bad[hostname',
code: 'ERR_INVALID_URL'
}
There was a problem hiding this comment.
Does that actually throw in the try/catch?
I think the URL contained the char [ when I tried in the REPL. My bad
trentm
approved these changes
Mar 19, 2024
Merged
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host header may contain invalid characters making the agent throw an exception and stoping the app. Agent should not throw and let the app deal with the wrong requerst.
Closes: #3874
Checklist