tests: refactor config tests service name #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
agent-nodejs
david-luna
commented
Dec 5, 2023
| const test = require('tape'); | ||
|
|
||
| const { normalize } = require('../../lib/config/config'); | ||
| const { CONFIG_SCHEMA, getDefaultOptions } = require('../../lib/config/schema'); | ||
|
|
||
| const { runTestFixtures } = require('../_utils'); | ||
| const { reviver, replacer } = require('./_json-utils.js'); | ||
| const { reviver, replacer } = require('./json-utils.js'); |
There was a problem hiding this comment.
Note for reviewer: nit from the previous PR #3768
david-luna
commented
Dec 5, 2023
| @@ -448,7 +452,7 @@ const testFixtures = [ | |||
| t.deepEqual( | |||
| resolvedConfig.globalLabels, | |||
| pairs, | |||
| 'globalLabels is parsed correctly from environment (array)', | |||
| 'globalLabels is parsed correctly from start options (array)', | |||
There was a problem hiding this comment.
Note for reviewer: nit from the previous PR #3768
david-luna
commented
Dec 5, 2023
| @@ -577,7 +581,7 @@ const testFixtures = [ | |||
| t.deepEqual( | |||
| resolvedConfig.ignoreUrlStr, | |||
| ['str1'], | |||
| 'string items of ignoreUrl are added to the right config (ignoreUrlStr)', | |||
| 'string items of ignoreUrls are added to the right config (ignoreUrlStr)', | |||
There was a problem hiding this comment.
Note for reviewer: nit from the previous PR #3768
david-luna
commented
Dec 5, 2023
| { | ||
| name: 'pkg-zero-conf-none - serviceName/serviceVersion resolved to unknown if no package.json present', | ||
| script: (function () { | ||
| const path = require('path'); |
There was a problem hiding this comment.
Note for reviewer: when this iife executes the requires at the top are not resolved yet. So we need to these ones
trentm
approved these changes
Dec 5, 2023
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring all test related to the resolution of the service name and version. It also moves the
test/fixtures/pkg-zero-conf-*folders used to test intotest/config/fixturesfolder to keep al related files in the same scope.Checklist