Skip to content

feat: improve SQL summarization to match cross-agent spec #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: improve SQL summarization to match cross-agent spec #2881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/sql-signature.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright Elasticsearch B.V. and other contributors where applicable.
* Licensed under the BSD 2-Clause License; you may not use this file except in
* compliance with the BSD 2-Clause License.
*/

'use strict'

// Test the Node.js APM agent's summarization of SQL statements used to set
// 'span.name' for DB spans against the cross-agent JSON spec.

const sqlSummary = require('sql-summary')
const tape = require('tape')

tape.test('cross-agent SQL statement summary/signature', function (t) {
const sqlSigCases = require('./fixtures/json-specs/sql_signature_examples.json')
sqlSigCases.forEach(sqlSigCase => {
let desc = JSON.stringify(sqlSigCase.input)
if (sqlSigCase.comment) {
desc += ' # ' + sqlSigCase.comment
}
t.equal(sqlSummary(sqlSigCase.input), sqlSigCase.output, desc)
})
t.end()
})