Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script] [astrology] refactor due to DRCMM.peer_telescope change #7125

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

hat071af
Copy link
Contributor

@hat071af hat071af commented Feb 26, 2025

Part 3 of 5 of a suite of astrology changes
-- Part 1: elanthia-online/lich-5#783 common-moonmage - update to peer_telescope for multi-line parsing of observation results
-- Part 2: #7127 base - addition of settings support for astrology and walkingastro changes
-- Part 3: #7125 astrology - refactor to account for peer_telescope change and addition of option to force vision predictions
-- Part 4: #7124 walkingastro - extensive quality of life changes to default behaviour and new optional features
-- Part 5: #7126 combat-trainer - refactor to account for peer_telescope change, no change to function

  • refactored to account for changes to multi-line parsing of peer_telescope
  • added astrology_force_visions: setting to allow turning off divination tool use for this script without having to remove divination tool from your yaml so that other scripts can still use the tool settings. Defaults to false.
  • added stowing of telescope and divination tool when script aborted

- refactored to account for changes to multi-line parsing of peer_telescope
- added `astrology_force_visions:` setting to allow turning off divination tool use for this script without having to remove divination tool from your yaml so that other scripts can still use the tool settings. Defaults to false.
@MahtraDR MahtraDR merged commit e23b5d6 into elanthia-online:main Mar 5, 2025
2 checks passed
MahtraDR pushed a commit that referenced this pull request Mar 5, 2025
Part 4 of 5 of a suite of astrology changes
-- Part 1: elanthia-online/lich-5#783
common-moonmage - update to peer_telescope for multi-line parsing of
observation results
-- Part 2: #7127 base - addition of settings support for astrology and
walkingastro changes
-- Part 3: #7125 astrology - refactor to account for peer_telescope
change and addition of option to force vision predictions
-- Part 4: #7124 walkingastro - extensive quality of life changes to
default behaviour and new optional features
-- Part 5: #7126 combat-trainer - refactor to account for peer_telescope
change, no change to function

Changes to default behaviour:
- Any version of lich:
-- added more year round constellations to expand from only using the
survival pool (currently this only selects the heralds/champions due to
wild magic event but regular constellation support for when that ends is
built in already)
-- added pausing of other scripts to better handle interference as a
background script
-- changed wait of 205 seconds between observations to additionally
trigger off of cooldown message.
-- added stowing of telescope and divination tool when script aborted
-- changed @tele_storage to @telescope_storage for consistency with
astrology script
-- changed some DRC commands to DRCMM for better handling
-- added bypass of observation step if all prediction pools are full
- Lich >5.11.0 required:
-- refactored to account for changes to multi-line parsing of
peer_telescope
-- added detection of full pools other than the one associated with
observed constellation to improve prediction logic
-- added detection of simultaneous partial and full pool messaging on
observation to more accurately detect when to predict.

New optional functionality:
- Any version of lich:
-- added option for a delay on startup
-- added toggle for using prediction tools instead of visions. Default
is to not use tools.
-- added toggle for using partial prediction pools. Default is to use
full pools.
-- added toggle for predicting without regard to mindstate. Useful for
more frequent predictions when attempting to bond tools or increase
prediction counter for titles. Default is to not predict if mindstate
above threshold of 25/34.
-- added option to analyze prediction tool after every prediction with a
tool. This only adds RT, so is useful only if wanting to log bond data.

New settings:
```
#settings for the ;walkingastro script
# Recommended to add Piercing Gaze to the walkingastro waggle set. 
# Clear Vision and Aura Sight are also useful there, but not as necessary.
walkingastro:
  startup_delay: 
  use_tools: 
  use_partial_pools: 
  # Setting walkingastro_predict_regardless_of_mindstate to true is meant to allow 
  # passive tool bonding via more frequent predictions, so also set 
  # walkingastro_use_partial_pools to false to maximize the chance of a bond if using it for that purpose.
  # Recommended to add Destiny Cipher to the walkingastro waggle set for this purpose as well.
  predict_regardless_of_mindstate: 
  # Set to true if you want to analyze your divination tool after every prediction.
  # Only useful for logging prediction tracking, does not add any in-game benefit.
  analyze_divination_tool: 
```
MahtraDR pushed a commit that referenced this pull request Mar 5, 2025
#7126)

…e changes

Part 5 of 5 of a suite of astrology changes
-- Part 1: elanthia-online/lich-5#783
common-moonmage - update to peer_telescope for multi-line parsing of
observation results
-- Part 2: #7127 base - addition of settings support for astrology and
walkingastro changes
-- Part 3: #7125 astrology - refactor to account for peer_telescope
change and addition of option to force vision predictions
-- Part 4: #7124 walkingastro - extensive quality of life changes to
default behaviour and new optional features
-- Part 5: #7126 combat-trainer - refactor to account for peer_telescope
change, no change to function
MahtraDR pushed a commit to elanthia-online/lich-5 that referenced this pull request Mar 5, 2025
refactor script to output multi-line array of results

Part 1 of 5 of a suite of astrology changes
- Part 1: #783 common-moonmage - update to peer_telescope for multi-line
parsing of observation results
- Part 2: elanthia-online/dr-scripts#7127 base -
addition of settings support for astrology and walkingastro changes
- Part 3: elanthia-online/dr-scripts#7125
astrology - refactor to account for peer_telescope change and addition
of option to force vision predictions
- Part 4: elanthia-online/dr-scripts#7124
walkingastro - extensive quality of life changes to default behaviour
and new optional features
- Part 5: elanthia-online/dr-scripts#7126
combat-trainer - refactor to account for peer_telescope change, no
change to function
@hat071af hat071af deleted the astrology branch March 6, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants