Fix room window not updating on .resize#35
Merged
Conversation
RoomWindow was missing a redraw method, so the resize handler fell through to Curses::Window#redraw (redrawwin) which only marks the window as damaged without re-rendering the room content. Add a redraw method that delegates to render. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoomWindowwas missing aredrawmethod, soWindowManager#resizefell through toCurses::Window#redraw(redrawwin) which only marks the window as damaged without actually re-rendering room content (title, description, objects, exits, etc.)RoomWindow#redrawthat delegates torenderTest plan
.resizecommand -- room window should update along with all other windows🤖 Generated with Claude Code