-Issue: #205: Merging (Identically Specified) MinHashLSH objects

[rupeshkumaar]

Merging two MinHashLSH of the same length (num_perm).

[rupeshkumaar]

@ekzhu I have raised a PR. I have tried to cover all the points that we had discussed. Please feel free to engage and let me know if any modification is required. Thank you!

[rupeshkumaar]

@ekzhu Resolved the conversations. Can you please go through the changes. Thank you. Let me know if there are any other changes.

[ekzhu]

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

[junrae6454]

@ekzhu When will this commit be merged?

[ekzhu]

@junrae6454 Still waiting for @rupeshkumaar's changes. Unless you want to help finishing this?

[rupeshkumaar]

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

[ekzhu]

Could you also add "3.12" to the tested python version:
https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

Thanks. Let me know when the changes are pushed

[rupeshkumaar]

Please do let me know, @ekzhu about the hashfunc for redis that I have asked. Thank you. Logging out for now. Once this is done I will push the changes.

[rupeshkumaar]

@ekzhu Please review.

[ekzhu]

Also, to fix the tests failure for now, remove 3.12 from python version.

[rupeshkumaar]

Please review @ekzhu

[ekzhu]

@rupeshkumaar merged, thank you for the hard work!!

[ekzhu]

@rupeshkumaar if you are interested, you can take a look at this issue #236 that broke the library for python 3.12

[rupeshkumaar]

Yeah, sure I will take a look. @ekzhu