Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e integration tests #8149

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix e2e integration tests #8149

merged 1 commit into from
Jan 20, 2025

Conversation

cheeseandcereal
Copy link
Contributor

@cheeseandcereal cheeseandcereal commented Jan 19, 2025

Description

This PR fixes the currently failing e2e tests. Specifically:

  • Skip checking the exact amount of access entries on a cluster
    • Previously, we were checking for exactly 4, because the tests created 3, and assumed 1 was created by default. Now, there has been a change in EKS which causes 2 access entries to be created by default. We could explicitly check for 5 now, but this may break again in the future if this behavior changes again. We already validate the elements we expect are in the slice, so this PR just removes the check for exact length of access entries entirely
  • Update auto-mode tests to check for at least 1 node to be created (instead of exactly 1).
    • Now that metrics-server addon is being created by default, auto-mode clusters typically come up with 2 nodes now. Instead of validating the exact amount of nodes, just assert there's more than 0, and perform the same checks as before across all the nodes.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added the skip-release-notes Causes PR not to show in release notes label Jan 19, 2025
@cheeseandcereal cheeseandcereal marked this pull request as ready for review January 19, 2025 04:07
@cheeseandcereal cheeseandcereal merged commit a9f115b into main Jan 20, 2025
10 checks passed
@cheeseandcereal cheeseandcereal deleted the fix-e2e-tests branch January 20, 2025 07:08
@cheeseandcereal cheeseandcereal restored the fix-e2e-tests branch January 20, 2025 07:08
@cheeseandcereal cheeseandcereal deleted the fix-e2e-tests branch January 20, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants