Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limit & offset options for API queries #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HGebhardt
Copy link
Contributor

Adds the ability for fetching only the specified amount of items. It's very useful for getting only one item with a specific ID (e.g.: Fastbill::Automatic::Article.get(article_number: "foobar", limit: 1)).

@victorblaga
Copy link
Contributor

Like
Am 06.11.2013 21:12 schrieb "Hendrik Gebhardt" [email protected]:

Adds the ability for fetching only the specified amount of items. It's
very useful for getting only one item with a specific ID (e.g.:

Fastbill::Automatic::Article.get(article_number: "foobar", limit: 1)).

You can merge this Pull Request by running

git pull https://github.com/HGebhardt/fastbill-automatic request-options

Or view, comment on, or merge it at:

#8
Commit Summary

  • add limit & offset options for API queries

File Changes

Patch Links:

@HGebhardt
Copy link
Contributor Author

Ok, Patrice told me that the filters are not implemented, yet. The example above doesn't work like expected.

@skorth
Copy link
Contributor

skorth commented Nov 7, 2013

You mean both, Limit & Offset?

@HGebhardt
Copy link
Contributor Author

the parameters limit & offset are working as expected, but ….get(article_number: "foobar", …) doesn't return the article with the article number "foobar". They will implement it, but it's not available yet.

@HGebhardt
Copy link
Contributor Author

If you have any concerns just ask us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants