Repository navigation
EK-2611: load the footer credit from EkLine's hosted script (2.7.0) - #25
Merged
Merged
Conversation
The footer had the credit's words and mark written into it, so a change to EkLine's credit needed a template release and an edit in every site built from the template. The footer now renders <ekline-credit> and loads https://ekline.io/v1/credit.js, the way docs.ekline.io does. It shows whatever wording that script serves. - Both copies of CustomFooter.astro change, in packages/template and in apps/docs. They stay identical. - The divider, the spacing above it and the text colour are unchanged. - The hosted component dims itself to 85%. 1.0.0 removed that from this footer because the text fell under 4.5:1, so the footer sets the component's `credit` part back to full opacity. Measured with the default palette: 4.76:1 in light, 6.78:1 in dark. - ekline-mark.svg is deleted from both projects. Only the footer used it. - The changelog entry tells adopters what this adds to their site: one request to ekline.io per page load, the need for JavaScript, and what a Content-Security-Policy has to allow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Preview verificationChecked on the two Vercel previews for commit
Not checked on a preview: how the credit renders. That needs a browser session signed in to Vercel. The markup and CSS served here are the same as in the local build that was rendered. After merge, look at the footer on https://potluck-demo.ekline.io and https://potluck.ekline.io. It shows "Maintained by EkLine" until ekline-io/ekline-app#3447 is deployed, and "Powered by EkLine" after. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: EK-2611. Related: ekline-io/ekline-app#3447 (EK-2610), which changes the credit's wording.
What this changes
The footer had the credit's words and mark written into it. A change to EkLine's credit therefore needed a template release, and an edit in every site built from the template. The footer now renders
<ekline-credit>and loadshttps://ekline.io/v1/credit.js, the way docs.ekline.io does. It shows whatever wording that script serves.packages/template/src/components/CustomFooter.astroandapps/docs/src/components/CustomFooter.astro. They were identical and stay identical.creditpart back to full opacity. Measured in Chrome with the default palette: 4.76:1 in light, 6.78:1 in dark.ekline-mark.svgis deleted from both projects. Only the footer used it.What sites built from the template get
ekline.ioon each page load, for a script of 4,059 bytes (1,947 compressed). Production sets no cookie on it, and the script contains nofetch, beacon, cookie or storage call.https://ekline.ioinscript-src. The template sets no policy.What it looks like
"EkLine" is semibold (was regular), and the mark is 13px (was 16px). The footer is 5px shorter.
The screenshots still say "Maintained by EkLine". That is expected. The footer shows what production
credit.jsserves, and that changes to "Powered by EkLine" when ekline-app#3447 is deployed. Nothing in this repository changes then.Not changed on purpose
README.mdline 6 andpackages/template/README.mdline 205 say who maintains the template. They are not the credit.package-lock.jsonkeeps"version": "2.5.0". The last two releases did not touch it either.Testing
npm run check:shippedpasses.npm run check: 0 errors inpackages/templateand inapps/docs.npm testinpackages/template: 183 passed, 0 failed, 13 skipped.npm testinapps/docs: 23 passed, 0 failed, 12 skipped.npm run test:visualinpackages/templateon macOS: 87 passed, 25 skipped. The only screenshot baseline is of the sidebar, so the footer is not in it.https://ekline.io/;ekline-credit:where(.astro-…)::part(credit){opacity:1}, and the computed opacity of the part is 1.Not tested: a real Content-Security-Policy that blocks the script. The blocked state was simulated by leaving the element undefined.
Follow-up outside this repository
ekline-app/ekline-docs/CLAUDE.mdlistsCustomFooter.astroas a file that differs from the template on purpose, because ekline-docs already used the hosted script. After this merges and ekline-docs is next synced, that row should be reviewed.Screenshots
Before is the live demo site. After is this branch, built locally.
🤖 Generated with Claude Code