Skip to content

Commit

Permalink
Merge pull request #881 from ejgallego/update_jsoo
Browse files Browse the repository at this point in the history
[js worker] Update js_of_ocaml to 5.9.1 and Coq -> Roqc / stdlib split
  • Loading branch information
ejgallego authored Dec 6, 2024
2 parents 3fa7fa1 + 2ad54c2 commit c110000
Show file tree
Hide file tree
Showing 7 changed files with 139 additions and 131 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,10 @@ jobs:

- name: 🐫🐪🐫 Get dependencies
run: |
opam update
opam exec -- make opam-deps
opam pin add js_of_ocaml-compiler --dev -y
opam pin add js_of_ocaml --dev -y
opam pin add js_of_ocaml-compiler -k version 5.9.1 -y
opam pin add js_of_ocaml -k version 5.9.1 -y
opam install zarith_stubs_js js_of_ocaml-ppx -y

- name: 💉💉💉 Patch Coq
Expand Down
7 changes: 7 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
- [fleche] fix quick fixes for errors being lost due to incorrect
handling of `send_diags_extra_data` (@ejgallego, #850)
- [vscode] Syntax highlighting for Coq 8.17-8.20 (@4ever2, #872)
- [build] Adapt to Coq -> Rocq renaming (@ejgallego, @proux, #879)
- [js worker] Update js_of_ocaml to 5.9.1 , thanks a lot to Hugo
Heuzard for longstanding continued support of the jsCoq and coq-lsp
projects (@ejgallego, @hhugo, #881)
- [js worker] Update stubs (@ejgallego, @hhugo, #881)
- [js worker] Fix build for Coq -> Rocq renaming and stdlib split
(@ejgallego, #881)

# coq-lsp 0.2.2: To Virtual or not To Virtual
---------------------------------------------
Expand Down
8 changes: 4 additions & 4 deletions controller-js/coq_lsp_worker.ml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ let coq_init ~debug =
let vm, warnings = (false, Some "-vm-compute-disabled") in
Coq.Init.(coq_init { debug; load_module; load_plugin; vm; warnings })

external coq_vm_trap : unit -> unit = "coq_vm_trap"
external rocq_vm_trap : unit -> unit = "rocq_vm_trap"

(* This code is executed on Worker initialization *)
let main () =
Expand All @@ -146,15 +146,15 @@ let main () =
setup_std_printers ();

(* setup_interp (); *)
coq_vm_trap ();
rocq_vm_trap ();

Lsp.Io.set_log_fn (fun n -> Lsp.Base.Message.notification n |> post_message);
let io = CB.cb in
Fleche.Io.CallBack.set io;

let stdlib coqlib =
let unix_path = Filename.concat coqlib "theories" in
let coq_path = Names.(DirPath.make [ Id.of_string "Stdlib" ]) in
let coq_path = Names.(DirPath.make [ Id.of_string "Corelib" ]) in
Loadpath.{ unix_path; coq_path; implicit = true; recursive = true }
in

Expand All @@ -176,7 +176,7 @@ let main () =
; ocamlpath
; vo_load_path
; ml_include_path = []
; require_libraries = [ (None, "Stdlib.Init.Prelude") ]
; require_libraries = [ (None, "Corelib.Init.Prelude") ]
; args = [ "-noinit"; "-boot" ]
}
in
Expand Down
2 changes: 1 addition & 1 deletion controller-js/dune
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
; --file=%{dep:coq-fs}
--setenv
PATH=/bin))
(link_flags -linkall -no-check-prims)
(link_flags -no-check-prims)
; The old makefile set: -noautolink -no-check-prims
(libraries
zarith_stubs_js
Expand Down
Loading

0 comments on commit c110000

Please sign in to comment.