-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic object declaration #120
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 98.79% 98.89% +0.10%
==========================================
Files 6 6
Lines 248 271 +23
==========================================
+ Hits 245 268 +23
Misses 3 3
Continue to review full report at Codecov.
|
I also had to create an object typecast function, which might not have ideal behavior, and probably should be in the same module the other typecasts come from; let me know if you want me to create a pull request for |
I added tests for the two functions I missed. @eivindfjeldstad Everything passes now and maintains code coverage. |
Will this get merged and published soon? desperately needed. |
There were compounding changes I needed, so I ended up creating josh-hemphill/valivar which is written in typescript and has dictionary/dynamic objects. It borrows heavily from this repo because I love the API. Oh, and valivar also supports Deno |
closes #102
All previous tests are passing, and relevant ones were made.
It seems to work reasonably well from what I can tell so far, I just emulated the behavior of how Arrays are handled to create an object key wildcard.
This would definitely have to be a major version change since there's a good chance this will break some people's implementation.
I also want to apologize for the ESLint changes, I have global ESLint and I was trying to prevent my global config from making sweeping stylistic changes.