Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke enhance #38

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Invoke enhance #38

merged 7 commits into from
Aug 17, 2023

Conversation

mariopil
Copy link
Member

@mariopil mariopil commented Aug 9, 2023

Following improvements have been made:

  • contracts code is dynamically loaded from github repo
  • list of contracts is also loaded from the repo (however this does not affect the contracts dropdown)
  • monaco editor has been used for the code editor
  • each contracts public method has now Invoke button - when clicked a dialog window with example invoke command is displayed
  • default values are used for contract method parameters - 1 for numeric values, a param_name_address for param_name variable of type Address
  • inputs for init method params have been removed
  • author and license inputs have been moved above buttons

@mariopil mariopil requested review from eloylp and geofmureithi August 9, 2023 07:30
@mariopil mariopil self-assigned this Aug 9, 2023
@mariopil mariopil linked an issue Aug 9, 2023 that may be closed by this pull request
@mariopil mariopil added this to the Milestone 1 milestone Aug 9, 2023
Copy link
Member

@eloylp eloylp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. It was easy to review. I really appreciated the PR description. Thanks for doing that.

The monaco editor looks awesome 🚀 . Well, all the enhancements in truth 😄

There is only one nitpick. It was hard to find the invoke button on each contract code public function. But maybe its just my resolution plus i am getting old:

image

I think we can move forward and check this later. Thanks for the great work !


export class ContractsRepoReader {
private readonly ghUrl =
'https://api.github.com/repos/eigerco/nebula/contents'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :) . No more copy/pasting ! 🚀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the button is a bit small. I'll check if there is a way to make it bigger.

@eloylp
Copy link
Member

eloylp commented Aug 16, 2023

Great ! thanks @mariopil . Should we merge this ?

@mariopil
Copy link
Member Author

Yeah, we can merge it :)

@mariopil mariopil merged commit 4082f7a into main Aug 17, 2023
@geofmureithi geofmureithi deleted the invoke_enhance branch September 19, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate new introspection capabilities of the Wizard UI
2 participants