-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke enhance #38
Invoke enhance #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. It was easy to review. I really appreciated the PR description. Thanks for doing that.
The monaco editor looks awesome 🚀 . Well, all the enhancements in truth 😄
There is only one nitpick. It was hard to find the invoke
button on each contract code public function. But maybe its just my resolution plus i am getting old:
I think we can move forward and check this later. Thanks for the great work !
|
||
export class ContractsRepoReader { | ||
private readonly ghUrl = | ||
'https://api.github.com/repos/eigerco/nebula/contents' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great :) . No more copy/pasting ! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the button is a bit small. I'll check if there is a way to make it bigger.
Great ! thanks @mariopil . Should we merge this ? |
Yeah, we can merge it :) |
Following improvements have been made:
Invoke
button - when clicked a dialog window with example invoke command is displayed1
for numeric values, aparam_name_address
forparam_name
variable of typeAddress
author
andlicense
inputs have been moved above buttons