Skip to content

chore: chatstore error catch #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2025
Merged

chore: chatstore error catch #707

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef58838
update
nitpicker55555 Nov 19, 2025
20f51fa
Merge branch 'main' into chore/ChatStore
nitpicker55555 Nov 19, 2025
f78e4c7
Merge main into chore/ChatStore
Wendong-Fan Nov 20, 2025
cc577e7
minor fix wendong
Wendong-Fan Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 96 additions & 37 deletions src/store/chatStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,27 @@ const chatStore = (initial?: Partial<ChatStore>) => createStore<ChatStore>()(
}) : undefined,

async onmessage(event: any) {
const agentMessages: AgentMessage = JSON.parse(event.data);
let agentMessages: AgentMessage;

try {
agentMessages = JSON.parse(event.data);
} catch (error) {
console.error('Failed to parse SSE message:', error);
console.error('Raw event.data:', event.data);

// Create error task to notify user
const currentStore = getCurrentChatStore();
const newTaskId = currentStore.create();
currentStore.setActiveTaskId(newTaskId);
currentStore.setHasWaitComfirm(newTaskId, true);
currentStore.addMessages(newTaskId, {
id: generateUniqueId(),
role: "agent",
content: `**System Error**: Failed to parse server message. The connection may be unstable.\n\nPlease try again or contact support if this persists.`,
});
return;
}

console.log("agentMessages", agentMessages);
const agentNameMap = {
developer_agent: "Developer Agent",
Expand Down Expand Up @@ -1033,7 +1053,15 @@ const chatStore = (initial?: Partial<ChatStore>) => createStore<ChatStore>()(
addWebViewUrl(currentTaskId, agentMessages.data.message as string, agentMessages.data.process_task_id as string)
}
if (agentMessages.data.method_name === 'browser_navigate' && agentMessages.data.message?.startsWith('{"url"')) {
addWebViewUrl(currentTaskId, JSON.parse(agentMessages.data.message)?.url as string, agentMessages.data.process_task_id as string)
try {
const urlData = JSON.parse(agentMessages.data.message);
if (urlData?.url) {
addWebViewUrl(currentTaskId, urlData.url as string, agentMessages.data.process_task_id as string)
}
} catch (error) {
console.error('Failed to parse browser_navigate URL:', error);
console.error('Raw message:', agentMessages.data.message);
}
}
let taskRunning = [...tasks[currentTaskId].taskRunning]

Expand Down Expand Up @@ -1191,53 +1219,84 @@ const chatStore = (initial?: Partial<ChatStore>) => createStore<ChatStore>()(
}

if (agentMessages.step === "error") {
console.error('Model error:', agentMessages.data)
const errorMessage = agentMessages.data.message || 'An error occurred while processing your request';
try {
console.error('Model error:', agentMessages.data);

// Mark all incomplete tasks as failed
let taskRunning = [...tasks[currentTaskId].taskRunning];
let taskAssigning = [...tasks[currentTaskId].taskAssigning];

// Update taskRunning - mark non-completed tasks as failed
taskRunning = taskRunning.map((task) => {
if (task.status !== "completed" && task.status !== "failed") {
task.status = "failed";
// Validate that agentMessages.data exists before processing
if (agentMessages.data === undefined || agentMessages.data === null) {
throw new Error('Invalid error message format: missing data');
}
return task;
});

// Update taskAssigning - mark non-completed tasks as failed
taskAssigning = taskAssigning.map((agent) => {
agent.tasks = agent.tasks.map((task) => {
// Safely extract error message with fallback chain
const errorMessage = agentMessages.data?.message ||
(typeof agentMessages.data === 'string' ? agentMessages.data : null) ||
'An error occurred while processing your request';

// Mark all incomplete tasks as failed
let taskRunning = [...tasks[currentTaskId].taskRunning];
let taskAssigning = [...tasks[currentTaskId].taskAssigning];

// Update taskRunning - mark non-completed tasks as failed
taskRunning = taskRunning.map((task) => {
if (task.status !== "completed" && task.status !== "failed") {
task.status = "failed";
}
return task;
});
return agent;
});

// Apply the updates
setTaskRunning(currentTaskId, taskRunning);
setTaskAssigning(currentTaskId, taskAssigning);
// Update taskAssigning - mark non-completed tasks as failed
taskAssigning = taskAssigning.map((agent) => {
agent.tasks = agent.tasks.map((task) => {
if (task.status !== "completed" && task.status !== "failed") {
task.status = "failed";
}
return task;
});
return agent;
});

// Complete the current task with error status
setStatus(currentTaskId, 'finished');
setIsPending(currentTaskId, false);
// Apply the updates
setTaskRunning(currentTaskId, taskRunning);
setTaskAssigning(currentTaskId, taskAssigning);

// Add error message to the current task
addMessages(currentTaskId, {
id: generateUniqueId(),
role: "agent",
content: `❌ **Error**: ${errorMessage}`,
});
uploadLog(currentTaskId, type)

// Stop the workforce
try {
await fetchDelete(`/chat/${project_id}`);
// Complete the current task with error status
setStatus(currentTaskId, 'finished');
setIsPending(currentTaskId, false);

// Add error message to the current task
addMessages(currentTaskId, {
id: generateUniqueId(),
role: "agent",
content: `❌ **Error**: ${errorMessage}`,
});
uploadLog(currentTaskId, type)

// Stop the workforce
try {
await fetchDelete(`/chat/${project_id}`);
} catch (error) {
console.log("Task may not exist on backend:", error);
}
} catch (error) {
console.log("Task may not exist on backend:", error);
console.error('Failed to handle model error:', error);
console.error('Original agentMessages:', agentMessages);

// Fallback: try to create error task with minimal operations
try {
const { create, setActiveTaskId, setHasWaitComfirm, addMessages } = get();
const fallbackTaskId = create();
setActiveTaskId(fallbackTaskId);
setHasWaitComfirm(fallbackTaskId, true);
addMessages(fallbackTaskId, {
id: generateUniqueId(),
role: "agent",
content: `**Critical Error**: An unexpected error occurred while handling a model error. Please refresh the application or contact support.`,
});
} catch (fallbackError) {
console.error('Failed to create fallback error task:', fallbackError);
// Last resort: just log the error without creating UI elements
console.error('Original error that could not be displayed:', agentMessages);
}
}
return;
}
Expand Down