enhance: mcp tools logs & mcp client stopping handling #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wendong-Fan
reviewed
Sep 17, 2025
backend/app/service/chat_service.py
Outdated
Comment on lines
440
to
444
| workforce.add_single_agent_worker( | ||
| "MCP Agent: A Model Context Protocol agent that provides access " | ||
| "to external tools and services through MCP integrations.", | ||
| mcp, | ||
| ) |
There was a problem hiding this comment.
thanks @a7m-1st , I think our system now support config the mcp via adding a new worker agent, so there's no need to add this special MCP Agent, could you double check this?
There was a problem hiding this comment.
oh okay, thanks for the review @Wendong-Fan, let me check
There was a problem hiding this comment.
- @Wendong-Fan , I have just reverted that code & adding a separate worker is working fine. I will make a another PR for some enhancements on Add worker along the way.
- So I guess this pr is only about enhanced mcp logging & mcp client termination handling.
a7m-1st
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
searchtool and a hidden error of "env config empty"Result & Discussion
jidfrom whatsapp api itself.What is the purpose of this pull request?