Add e2e tests for the ETOS controller #410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test will deploy the controller and a fully functioning ETOS cluster and then deploy an ETOS testrun and wait for it to succeed. We only test the v1alpha version of ETOS at the moment but we could extend the actual test that we run in the testrun to start up a v0 testrun as well to verify that it works as expected.
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
fredjn
reviewed
Apr 30, 2025
| @@ -401,7 +401,7 @@ spec: | |||
| default: "" | |||
| type: string | |||
| host: | |||
| default: eventrepository | |||
| default: "" | |||
There was a problem hiding this comment.
Whats the rationale behind this change?
There was a problem hiding this comment.
That default would never work so we added a better way to set the default down in the eventrepository.go file:
https://github.com/eiffel-community/etos/pull/410/files#diff-30f86aebbd880d7c00ec6a5e7a3e2869e21f9c1f4868f6a3618f4e6c195eca1dR98-R100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
This is a continuation of #405
Description of the Change
The test will deploy the controller and a fully functioning ETOS cluster and then deploy an ETOS testrun and wait for it to succeed.
We only test the v1alpha version of ETOS at the moment but we could extend the actual test that we run in the testrun to start up a v0 testrun as well to verify that it works as expected.
Alternate Designs
I would want to separate the tests a bit so that we don't have a single massive function, but sadly I am not well versed enough with ginkgo to understand how that can be done in an efficient way yet.
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]