Skip to content

Strict enforcement of allowed link types #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fredjn
Copy link
Member

@fredjn fredjn commented Feb 7, 2023

Applicable Issues

Fixes #347

Description of the Change

This patch adds an enum of allowed link types to all the event schemas

Alternate Designs

None

Benefits

Makes it harder to misuse the protocol, and to create/send events with improper link types.

Possible Drawbacks

The change might break services that implement validation but currently send events with arbitrary link types.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Fredrik Fristedt <[email protected]>

This patch adds an enum of allowed link types for all events
@fredjn fredjn requested a review from a team as a code owner February 7, 2023 17:10
@fredjn
Copy link
Member Author

fredjn commented Feb 7, 2023

I just realized that the schemas are generated. I will revise the PR with a commit to cater for that instead.

@fredjn
Copy link
Member Author

fredjn commented Feb 7, 2023

This became a bit more problematic than I first anticipated, holding off a bit until I have had time to discuss with someone from TC.

@fredjn
Copy link
Member Author

fredjn commented Feb 8, 2023

As it happens this had already been reported and denied(?) - Ref. #148

@fredjn fredjn closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict enforcement of allowed link types
1 participant