-
Notifications
You must be signed in to change notification settings - Fork 30
feat: split B0 from central detector tracking #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ideally would this happen after the PID or even cluster matching as none of the tracks should be able to match the central PID or calorimeter detectors? One thing this change could adversely effect is the important contribution of the B0 to vertexing. |
The B0 tracks are recombined with central tracks before we do vertexing. |
Do you not need to combine the Central and B0 CKFActsTrajectories when passed into the iterative vertex finder? |
Capybara summary for PR 1744
|
This comment was marked as resolved.
This comment was marked as resolved.
Is creating a collection which adds both vectors of trajectories not as simple with Acts internal types? Would it instead be possible to make the iterative vertex finder input variadic and pass both collections. |
Variadic doesn't work since only one Acts::TrackContainer has to be passed as input. We'd need to create a new container and add all tracks one by one. |
20c61be
to
d00f6cd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
0b6ce3e
to
b6dbbad
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b6dbbad
to
0b6ce3e
Compare
88b83b6
to
9021c5b
Compare
9021c5b
to
0536a97
Compare
Briefly, what does this PR introduce?
There is no way a relevant track can have both hits in the forward endcaps and the B0 tracker. We can therefore separate the tracking of both, and by doing so gain in the combinatoric search space and allow for parallelization.
This PR splits the B0 tracker seeding and tracking from the central detector seeding and tracking. After separate tracking, the tracks are merged again in the
ReconstructedChargedWithoutPIDParticles
collection.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.