Skip to content

feat: split B0 from central detector tracking #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Feb 26, 2025

Briefly, what does this PR introduce?

There is no way a relevant track can have both hits in the forward endcaps and the B0 tracker. We can therefore separate the tracking of both, and by doing so gain in the combinatoric search space and allow for parallelization.

This PR splits the B0 tracker seeding and tracking from the central detector seeding and tracking. After separate tracking, the tracks are merged again in the ReconstructedChargedWithoutPIDParticles collection.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@simonge
Copy link
Contributor

simonge commented Feb 26, 2025

Ideally would this happen after the PID or even cluster matching as none of the tracks should be able to match the central PID or calorimeter detectors?

One thing this change could adversely effect is the important contribution of the B0 to vertexing.

@wdconinc
Copy link
Contributor Author

One thing this change could adversely effect is the important contribution of the B0 to vertexing.

The B0 tracks are recombined with central tracks before we do vertexing.

@simonge
Copy link
Contributor

simonge commented Feb 26, 2025

One thing this change could adversely effect is the important contribution of the B0 to vertexing.

The B0 tracks are recombined with central tracks before we do vertexing.

Do you not need to combine the Central and B0 CKFActsTrajectories when passed into the iterative vertex finder?

https://github.com/eic/EICrecon/pull/1744/files#diff-e093c4fb16d0a0c3255aa88be403f9ea77ce7ac00a8120f47b34c8de55b30bd9L232-L238

@wdconinc

This comment was marked as resolved.

@simonge
Copy link
Contributor

simonge commented Mar 10, 2025

Do you not need to combine the Central and B0 CKFActsTrajectories when passed into the iterative vertex finder?

Yeah, and that's hard. Showstopper for now.

Is creating a collection which adds both vectors of trajectories not as simple with Acts internal types? Would it instead be possible to make the iterative vertex finder input variadic and pass both collections.

@wdconinc
Copy link
Contributor Author

Do you not need to combine the Central and B0 CKFActsTrajectories when passed into the iterative vertex finder?

Yeah, and that's hard. Showstopper for now.

Is creating a collection which adds both vectors of trajectories not as simple with Acts internal types? Would it instead be possible to make the iterative vertex finder input variadic and pass both collections.

Variadic doesn't work since only one Acts::TrackContainer has to be passed as input. We'd need to create a new container and add all tracks one by one.

@veprbl

This comment was marked as resolved.

@wdconinc

This comment was marked as resolved.

@wdconinc wdconinc marked this pull request as draft March 31, 2025 21:20
@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: far-backward Reconstruction related to far backward detectors topic: infrastructure topic: barrel topic: forward topic: backward topic: jets topic: digitization labels Apr 14, 2025
@wdconinc wdconinc force-pushed the separate-b0-tracking branch 3 times, most recently from 0b6ce3e to b6dbbad Compare April 14, 2025 18:24
@wdconinc wdconinc marked this pull request as ready for review April 14, 2025 18:25
@wdconinc

This comment was marked as resolved.

@wdconinc
Copy link
Contributor Author

The number of tracks now found in the B0 chain is consistent with the decrease in the Central chain.
Screenshot_20250415-203431 Screenshot_20250415-203447

@wdconinc wdconinc force-pushed the separate-b0-tracking branch from 88b83b6 to 9021c5b Compare April 23, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: digitization topic: far-backward Reconstruction related to far backward detectors topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: jets topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants