Always load version.rb, suppress legacy deprecation warning #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
reviewed
Sep 22, 2024
contracts.gemspec
Outdated
Comment on lines
17
to
22
| if Contracts::VERSION < "0.17" | ||
| s.post_install_message = " | ||
| 0.16.x will be the supporting Ruby 2.x and be feature frozen (only fixes will be released) | ||
| For Ruby 3.x use 0.17.x or later | ||
| " | ||
| end |
There was a problem hiding this comment.
Might as well just remove the whole message for 0.17+ = master
vlad-pisanov
force-pushed
the
vp_version
branch
from
de32e70 to
79d3f78
Compare
PikachuEXE
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor improvements:
version.rb, so thatContracts::VERSIONis always accessible to user