Draft
Conversation
LD gets passed as SHLIB_LD by the main Makefile to module making, if shared modules are desired. That already includes -shared which should really be in LDFLAGS instead ... To avoid breaking the build system, just use CC directly, which is already properly split from CFLAGS to use it here.
Member
|
instead of removing the static specifier for functions, we should first check, if the function could be moved to stay static. for example, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: thommey
Patch by: thommey
One-line summary:
Remove C file amalgamations (huge .c file by #include of other .c files) in modules
Additional description (if needed):
This drastically improves IDE support. irc_proto.h is the internal header file for irc.mod interdependencies. The key strategy to minimal build system changes is incremental linking of multiple .o files into a single .o file:
Disclaimer: 90% AI generated (Claude Opus 4.6)