Crash fix heap-use-after-free#1846
Open
michaelortmann wants to merge 1 commit intoeggheads:developfrom
Open
Conversation
…t because dcc table can be realloced
michaelortmann
added a commit
to michaelortmann/eggdrop
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes:
One-line summary:
Fix a pointer in dcc table linking into dcc table. We must not do that because dcc table can be realloced
Additional description (if needed):
Between dns resolve start and finish, realloc can happen here:
eggdrop/src/dccutil.c
Line 89 in d317ac2
like when someone connects to the eggdrrop at the right moment
Its a heap-use-after-free
When investigating the code i realized the dns_info.ip pointer is redundant, and the fix equals a cleanup.
Test cases demonstrating functionality (if applicable):