Enhance error logging for failed connect#1843
Open
michaelortmann wants to merge 6 commits intoeggheads:developfrom
Open
Enhance error logging for failed connect#1843michaelortmann wants to merge 6 commits intoeggheads:developfrom
michaelortmann wants to merge 6 commits intoeggheads:developfrom
Conversation
…ssl]:port, aware of ipv6 and tls
vanosg
reviewed
Jan 18, 2026
Member
|
Can you deconflict please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes:
One-line summary:
Enhance error logging for failed connect
Additional description (if needed):
Useful to relate log messages to each other and make it very clear what exactly failed
#1755 already enhanced logging, and this PR enhances it further
Propagate getsockopt error to errno error logging
Test cases demonstrating functionality (if applicable):
Before:
After:
Also getsockerrors like ENETUNREACH are properly propagated to error logging:
Before:
After: