Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes: #1762
One-line summary:
Additional description (if needed):
get_data_ptr()->n_malloc()could destroyline, so copylinetoline_rto makeappend_line()reentrantTurn paging off before booting a user in case of too many page lines to avoid infinite loop
Rise max page lines from 1000 to 2000
Add tcl command doc for tcl_page
Remember: If user is for example HQ, then
do_boot()will automatically re-login, and set the console page status to the value stored in console mod, if that mod is loaded, eventually triggering an infinite loop / segfault.In addition to finding the bug in February 2025 with #1762, and fixing it, i have now also been able to automatically find it flexing https://github.com/AFLplusplus/AFLplusplus
Test cases demonstrating functionality (if applicable):
Create a motd with 1003 lines
log in with HQ, like with
./eggdrop -t eggdrop.confThis was only one example to trigger the bug. Another one is having many ignores and doing the following will crash the bot: