feat!: allow PDKs without diode, antenna, and/or decap cells #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PDKs have self-tapping standard cells, do not suffer from the antenna effect, have no endcap cell, or a combination of those. This patch makes the variables options and modifies included steps to no longer assume their existence.
kareefardi
requested changes
Feb 12, 2025
| @@ -718,6 +718,10 @@ def run(self, state_in: State, **kwargs) -> Tuple[ViewsUpdate, MetricsUpdate]: | |||
| info("'DIODE_ON_PORTS' is set to 'none': skipping…") | |||
| return {}, {} | |||
|
|
|||
| if self.config["DIODE_CELL"] is None: | |||
| info("DIODE_CELL not set. Skipping…") | |||
There was a problem hiding this comment.
add {self.id} for consistency with
openlane2/openlane/steps/openroad.py
Line 1162 in 53f5e7d
Metric comparisons are in beta. Please report bugs under the issues tab.
Full tables ► https://gist.github.com/openlane-bot/7f6c4add19013cb7a702ca8c1c4c7d43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PDKs have self-tapping standard cells, do not suffer from the antenna effect, have no endcap cell, or a combination of those.
This patch makes the variables options and modifies included steps to no longer assume their existence.
Resolves #554