Use VERILOG_INCLUDE_DIRS in Verilator #661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fkwilken <[email protected]>
Signed-off-by: fkwilken <[email protected]>
donn
requested changes
Feb 12, 2025
openlane/steps/verilator.py
Outdated
| @@ -158,6 +163,10 @@ def run(self, state_in: State, **kwargs) -> Tuple[ViewsUpdate, MetricsUpdate]: | |||
| if self.config["LINTER_ERROR_ON_LATCH"]: | |||
| extra_args.append("--Werror-LATCH") | |||
|
|
|||
| if include_dirs := self.config["VERILOG_INCLUDE_DIRS"]: | |||
| include_flags = ["-I" + str(dir) for dir in include_dirs] | |||
There was a problem hiding this comment.
The way you've coded this, all the includes would be one argument, which, so if you have two directories, it would be:
-Idir1 -Idir2
This would include the directory literally named dir1 -Idir2, which is neither directory.
This can be fixed pretty easily: Replace 167, 168 with just this.
Suggested change
| include_flags = ["-I" + str(dir) for dir in include_dirs] | |
| extra_args.extend([f"-I{dir}" for dir in include_dirs]) |
Signed-off-by: fkwilken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to The-OpenROAD-Project/OpenLane#2046