Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: make substitutions more predictable, strictly class-level #648

Merged
merged 16 commits into from
Feb 10, 2025

Conversation

donn
Copy link
Member

@donn donn commented Jan 26, 2025

Misc. Enhancements/Bugfixes

  • openlane.flows

    • SequentialFlow
      • Substitutions are now to be strictly consumed by the subclass initializer,
        i.e., it can no longer be done on the object-level and only on the class
        level. Additionally, it can provided as a list of tuples instead of a
        dictionary so the same key may be reused multiple times.
      • Step IDs are re-normalized after every substitution, so a substitution for
        OpenROAD.DetailedPlacement-1 for example would always refer to the
        second OpenROAD.DetailedPlacement AFTER applying all previous
        substitutions, instead of the second "original"
        OpenROAD.DetailedPlacement in the flow.
  • openlane.config

    • meta.substituting_steps now only apply to the sequential flow declared in
      meta.flow and not all flows.

Resolves #646

@donn donn requested a review from kareefardi January 26, 2025 15:41
@donn donn changed the title feat: make substitutions more predictable, strictly class-level feat!: make substitutions more predictable, strictly class-level Jan 26, 2025
@openlane-bot
Copy link
Collaborator

openlane-bot commented Jan 26, 2025

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/64d795876674042cab631d968a702b3a

@donn donn merged commit 53f5e7d into dev Feb 10, 2025
109 checks passed
@donn donn deleted the fix_substitutions branch February 13, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants