-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: make substitutions more predictable, strictly class-level #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, normalize step ids after every substitution
* Updated nix-eda * Updated KLayout to `0.29.10` * Updated Magic to `8.3.515` * Updated Netgen to `1.5.291` * Updated OpenROAD to `655640a` * Adds new DFT features * Updated Volare to `0.20.5`
Metric comparisons are in beta. Please report bugs under the issues tab.
Full tables ► https://gist.github.com/openlane-bot/64d795876674042cab631d968a702b3a |
kareefardi
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc. Enhancements/Bugfixes
openlane.flows
SequentialFlow
i.e., it can no longer be done on the object-level and only on the class
level. Additionally, it can provided as a list of tuples instead of a
dictionary so the same key may be reused multiple times.
OpenROAD.DetailedPlacement-1
for example would always refer to thesecond
OpenROAD.DetailedPlacement
AFTER applying all previoussubstitutions, instead of the second "original"
OpenROAD.DetailedPlacement
in the flow.openlane.config
meta.substituting_steps
now only apply to the sequential flow declared inmeta.flow
and not all flows.Resolves #646