Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: draw isosub over the design #583

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: draw isosub over the design #583

wants to merge 3 commits into from

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 16, 2024 •
edited by donn
Loading

Steps

  • Magic.AddIsosub
    • New standalone step to draw isosub over the design bounding box.
  • Magic.StreamOut
    • Added MAGIC_ADD_ISOSUB to enable drawing isosub over the design bounding box.
  • KLayout.StreamOut
    • Added KLAYOUT_ADD_ISOSUB to enable drawing isosub over the design bounding box.
    • Added ISOSUB_LAYER, a pdk variable, specifying the layer/datatype pairing for isosub layer.

Resolves #531

@kareefardi
Copy link
Collaborator Author

@donn Thought on the name "isosub"?

@kareefardi kareefardi requested a review from donn October 16, 2024 12:21
@openlane-bot
Copy link
Collaborator

openlane-bot commented Oct 16, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • Changes to critical metrics were detected in the following designs:
    • sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/b44a21781841301e2fc5fcc2835e6d25

donn
donn requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor adjustments needed

openlane/steps/magic.py Outdated Show resolved Hide resolved
openlane/steps/magic.py Show resolved Hide resolved
openlane/config/pdk_compat.py Show resolved Hide resolved
openlane/steps/klayout.py Outdated Show resolved Hide resolved
@kareefardi kareefardi requested a review from donn January 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn Awaiting requested review from donn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kareefardi @openlane-bot @donn