-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update housekeeping_spi.v #411
base: main
Are you sure you want to change the base?
Conversation
Nobody is going to merge a pull request that comes without a description, discussion, or justification. |
Restructuring the housekeeping spi FSM to be more clean so that each always block handle only one register and there is no register updated in more than one always block. |
@NouranAbdelaziz What verification have you done on these changes? cc: @DavidRLindley |
@NouranAbdelaziz What verification have you done? |
@NouranAbdelaziz will this change require a re-synthesis of |
This RTL change was requested by @shalan when I was implementing Caravel on FPGA two years ago, in an attempt to make the housekeeping SPI function work correctly. However, I believe the RTL structure wasn’t the actual issue, and both implementations would likely synthesize to the same result. The change primarily makes the RTL more readable. I’m not sure if it’s still required. I believe I partially verified it on FPGA, but I cannot confirm that it has been fully verified. |
No description provided.