Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update housekeeping_spi.v #411

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NouranAbdelaziz
Copy link
Member

No description provided.

@RTimothyEdwards
Copy link
Contributor

Nobody is going to merge a pull request that comes without a description, discussion, or justification.

@NouranAbdelaziz
Copy link
Member Author

Restructuring the housekeeping spi FSM to be more clean so that each always block handle only one register and there is no register updated in more than one always block.

@marwaneltoukhy
Copy link
Member

@NouranAbdelaziz What verification have you done on these changes?

cc: @DavidRLindley

@DavidRLindley
Copy link
Contributor

@NouranAbdelaziz What verification have you done?

@d-m-bailey
Copy link
Contributor

@NouranAbdelaziz will this change require a re-synthesis of caravel_core/caravan_core?

@NouranAbdelaziz
Copy link
Member Author

NouranAbdelaziz commented Feb 9, 2025

This RTL change was requested by @shalan when I was implementing Caravel on FPGA two years ago, in an attempt to make the housekeeping SPI function work correctly. However, I believe the RTL structure wasn’t the actual issue, and both implementations would likely synthesize to the same result. The change primarily makes the RTL more readable. I’m not sure if it’s still required. I believe I partially verified it on FPGA, but I cannot confirm that it has been fully verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants