-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value for multi_touch event publishing #90
Conversation
fixes edwardtfn#74 Value was "OFF" instead of "ON"
WalkthroughThe pull request modifies the ESPHome configuration file for touch events, specifically updating the state publishing for multi-touch and swipe events. The changes involve switching the state of various binary sensors from Changes
Assessment against linked issues
The changes directly address the issue reported in #74, where the multitouch event was not updating. By changing the state to Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_touch.yaml (1)
319-322
: Consider documenting the event state behavior.While the implementation is correct, it would be helpful to add a brief comment explaining that the
ON
state indicates event occurrence, especially since this behavior was previously incorrect.Add a comment like this:
- id: touch_on_multi_touch_release mode: restart then: # Extended by: # - HW Buttons # - HW Vibration + # Publishes ON state to indicate multi-touch release event occurrence - binary_sensor.template.publish: id: bs_multi_touch state: ON # yamllint disable-line rule:truthy
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_touch.yaml
(1 hunks)
🔇 Additional comments (1)
ESPHome/TX-Ultimate-Easy-ESPHome_core_hw_touch.yaml (1)
321-321
: LGTM! This fixes the multi-touch event state.The change from
OFF
toON
correctly fixes the state publishing for multi-touch release events, ensuring proper event signaling. This aligns with the expected behavior where touch events should trigger an "ON" state to indicate the event occurred.
fixes #74
Value was "OFF" instead of "ON"
Summary by CodeRabbit