Support ediff and smerge modes to view diffs

[ChetanKoneru]

• Put together a hack to cleanup buffers ediff creates, else there are going to be dangling buffers like so

Note: I have in-line comments for the review, will delete it before merging.

Should fix #13

[ericdallo]

Looks interesting! will review later today

[ChetanKoneru]

Looks interesting! will review later today

Cool, in both ediff and smerge cases we are creating a new frame and deleting frame(and diff buffers) after we quit q the diff. I thought this is a cleaner approach rather than using the same frame we are working on.

BTW the frame always opens full screen, I prefer it and I think users would also prefer viewing side-by-side diff in a full screen frame.

[ericdallo]

@CsBigDataHub I tested and that looks really nice!

But can we please do not use frames for this feature? I understand your rationale but I don't think that's a good way, I never saw a emacs package open frames for anytihng, and there are so many cases to handle when going with that approach.
I'm pretty confortable in opening a new window or just the diff buffer like gptel.el, buffers are way easier for people to manage with their own rules if needed.

I will take a closer look to code then

[ericdallo]

I did some improvement to show buttons on the bottom instead of right too, sorry for the conflicts, can you solve it please?
Also, you don't need to close the PR like before, you can do the changes in this branch/PR

[ChetanKoneru]

@ericdallo fixed merge conflicts and creating windows in the same frame rather than creating new frames. There are in-line comments and function docs for your reference, I will clean these up when we are ready to merge.

[ericdallo]

Thanks @CsBigDataHub, will test in a couple of mins

[ericdallo]

That's great, thank you a lot!

ediff still behaves weird to me, when quitting ediff, I lost the buffer I was and eca-chat beomes the main buffer which is weird, smerge tho behaves perfectly, typeing ESC quit the buffer and goes back to old behavior.
Will merge but let me know if you know how to improve that for ediff

[ericdallo]

I noticed we lost the changes I did to actions who in the next line, will check that

[ChetanKoneru]

That's great, thank you a lot!

ediff still behaves weird to me, when quitting ediff, I lost the buffer I was and eca-chat beomes the main buffer which is weird, smerge tho behaves perfectly, typeing ESC quit the buffer and goes back to old behavior. Will merge but let me know if you know how to improve that for ediff

Huh, I tested it and did not notice the issue, I am capturing window configuration and restoring once user quit ediff or smerge.

Also I am binding q to quit both modes. Let me test again.

Should be a easy fix.

[ChetanKoneru]

I noticed we lost the changes I did to actions who in the next line, will check that

Can you please let me know where? I mean which function.

[ericdallo]

@CsBigDataHub Just pushed the fix, don't mind it!

The ediff one would be nice to improve, what happens is:

1. I have my eca-chat opened like that:

2. I click on view_diff and see the ediff as a whole window, so far so good

3. I type q and confirm, exists ediff, but now my chat is whole fullscreen, and I lost old buffer:

[ChetanKoneru]

oh, let me see if there is race condition introduced. Will test and push a fix tomorrow