Skip to content

Fix clipboard paste crash when selection offers a single target - #311

Merged
ericdallo merged 1 commit into
editor-code-assistant:masterfrom
forgoty:master
Sep 8, 2026
Merged

ericdallo merged 1 commit into
editor-code-assistant:masterfrom
forgoty:master

Conversation

@forgoty

@forgoty forgoty commented Sep 7, 2026

Copy link
Copy Markdown

Resolves the issue with some X11 clients
(e.g. st) only advertise a single selection target, in which case Emacs returns a bare symbol instead of a sequence. Passing that symbol straight into seq-some crashed paste in the eca chat and compose buffers with:
"seq-do: Wrong type argument: sequencep, UTF8_STRING" message.

Resolves the issue with some X11 clients
(e.g. st) only advertise a single selection target, in
which case Emacs returns a bare symbol instead of a sequence.
Passing that symbol straight into `seq-some` crashed paste in the
eca chat and compose buffers with:
"seq-do: Wrong type argument: sequencep, UTF8_STRING" message.
@forgoty

forgoty commented Sep 7, 2026

Copy link
Copy Markdown
Author

Hi,

Please let me know if I need to improve the tests or implementation somehow. I didn't find any contributors guide so just tried to apply the same style from existing source code and commits.

@ericdallo ericdallo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!

@ericdallo
ericdallo merged commit 836e7e0 into editor-code-assistant:master Sep 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants