Repository navigation
Add space after colon in completing-read for eca-chat-select-model - #274
Merged
Conversation
risset
changed the title
eca-chat-select-model
ericdallo
merged commit Jul 20, 2026
b49b4af
into
editor-code-assistant:master
0 of 15 checks passed
ericdallo
added a commit
that referenced
this pull request
Jul 23, 2026
The completing-read stub matched the exact prompt string, which #274 changed to end with ": ". Update the stub and use the same prompt format for the variant and agent prompts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed this today and it was bugging me :)
Btw thanks for this package and ECA in general!