Repository navigation
Conversation
Ensure finishing one chat cannot clear another chat's running subagent timer or related tool state.
ericdallo
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Each chat now keeps its tool and sub-agent state separate.
Previously, several hash tables were marked as buffer-local but were initialized with shared mutable values. As a result, newly created chat buffers could still reference the same underlying state.
This affected:
Why it only happened sometimes
The problem required a particular sequence of events:
Normal updates usually affected unique tool-call IDs, so they did not obviously interfere with other chats. The problem became visible when a chat cleared an entire shared hash table, which also removed state belonging to other chats.
This made the behavior appear intermittent, but it depended on the timing and order of activity across multiple chats.
Testing
Added a regression test that verifies finishing tool activity in one chat does not clear a sub-agent’s elapsed-time state in another chat.