Repository navigation
Conversation
`eca-chat--key-pressed-deletion' guarded the prompt boundary by dinging on any deletion at the prompt-field start, ignoring direction. That swallowed the forward `delete-char' issued by `C-d' and, under evil, the `~' (`evil-invert-char'), `r', `x' and `s' operators, so they left the first character in place (`~' prepended the inverted char instead of replacing it). At the prompt-field start, ding only for backward-deleting commands (and a negative delete count); forward deletions fall through and remove the first char. The guard above the prompt field is unchanged. Add a regression test and a changelog entry.
agzam
marked this pull request as ready for review
July 14, 2026 23:00
agzam
added a commit
to agzam/.emacs.d
that referenced
this pull request
Jul 15, 2026
The advice let evil's forward operators (~, r, x, s) delete the first prompt char, which eca-chat--key-pressed-deletion swallowed regardless of direction. Fixed upstream, so the workaround is no longer needed: editor-code-assistant/eca-emacs#271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eca-chat--key-pressed-deletion, which dinged on any deletion at the prompt-field start regardless of direction. SoC-dand, under evil,~(evil-invert-char),r,xandsleft the first char in place -~prepended the inverted char instead of replacing it.delete-charplus the evil operators) and a CHANGELOG entry.Testing
buttercup: 104 specs, 0 failed.