-
Notifications
You must be signed in to change notification settings - Fork 0
Combine quotation mark patterns to reduce verbosity #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: edithatogo <[email protected]>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates two related quotation mark detection patterns (curly quotes and single quotes as primary delimiters) into a single "Quotation Mark Issues" pattern to reduce verbosity. The change updates Pattern blader#18 from detecting only curly quotes to detecting both curly quotes and single quotes used as primary delimiters.
Changes:
- Combined Pattern blader#18 (Curly Quotation Marks) and the proposed Pattern blader#19 (Primary Single Quotes) into a single "Quotation Mark Issues" pattern
- Updated the
last_synceddate from 2026-01-31 to 2026-02-06 across adapter files - Updated all references to Pattern blader#18 in the SEVERITY CLASSIFICATION sections
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core_patterns.md | Source file updated with combined Pattern blader#18 including both curly and single quote issues |
| SKILL.md | Root skill file updated with combined pattern and updated references |
| SKILL_PROFESSIONAL.md | Professional variant updated with combined pattern and updated references |
| adapters/vscode/HUMANIZER.md | VSCode adapter synced with combined pattern; metadata repositioned |
| adapters/qwen-cli/QWEN.md | Qwen CLI adapter synced with combined pattern; metadata repositioned |
| adapters/gemini-extension/GEMINI_PRO.md | Gemini Pro adapter synced with combined pattern; metadata repositioned |
| adapters/gemini-extension/GEMINI.md | Gemini adapter synced with combined pattern; metadata repositioned |
| adapters/copilot/COPILOT.md | Copilot adapter synced with combined pattern; metadata repositioned |
| adapters/antigravity-skill/SKILL_PROFESSIONAL.md | Antigravity Pro skill synced with combined pattern; metadata repositioned |
| adapters/antigravity-skill/SKILL.md | Antigravity skill synced with combined pattern; metadata repositioned |
| adapters/antigravity-rules-workflows/README.md | Antigravity workflows synced with combined pattern; metadata repositioned |
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: antigravity-rules-workflows | ||
| adapter_format: Antigravity rules/workflows | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: vscode | ||
| adapter_format: VSCode markdown | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer-pro | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL_PROFESSIONAL.md | ||
| adapter_id: gemini-extension-pro | ||
| adapter_format: Gemini extension | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: copilot | ||
| adapter_format: Copilot instructions | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer-pro | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL_PROFESSIONAL.md | ||
| adapter_id: antigravity-skill-pro | ||
| adapter_format: Antigravity skill | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| ### 18. Quotation Mark Issues | ||
|
|
||
| **Problem:** ChatGPT uses curly quotes (“...”) instead of straight quotes ("..."). | ||
| **Problem:** AI models make two common quotation mistakes: | ||
| 1. Using curly quotes (“...”) instead of straight quotes ("...") | ||
| 2. Using single quotes ('...') as primary delimiters (from code training) | ||
|
|
||
| **Before:** | ||
| > He said “the project is on track” but others disagreed. | ||
| > She stated, 'This is the final version.' | ||
|
|
||
| **After:** | ||
| > He said "the project is on track" but others disagreed. | ||
| > She stated, "This is the final version." |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CODEX.md adapter file was not updated to reflect the combined Pattern blader#18 changes. This file still contains the old "Curly Quotation Marks" pattern at line 95 and lacks the new combined "Quotation Mark Issues" pattern that includes both curly quotes and single quote issues. For consistency, this adapter should be updated the same way as the other 8 adapter files in this PR.
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: qwen-cli | ||
| adapter_format: Qwen CLI context | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: gemini-extension | ||
| adapter_format: Gemini extension | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
| adapter_metadata: | ||
| skill_name: humanizer | ||
| skill_version: 2.2.0 | ||
| last_synced: 2026-02-06 | ||
| source_path: SKILL.md | ||
| adapter_id: antigravity-skill | ||
| adapter_format: Antigravity skill | ||
| --- |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.
User description
Addresses feedback from blader#5 that creating a separate pattern for single quotes was verbose.
Changes
Combined Pattern feat: modular skill fragments and humanizer-pro variant blader/humanizer#18 and proposed Pattern docs: migrate WARP.md to Agents.md standard blader/humanizer#19 into "Quotation Mark Issues"
"..."→"...")'...'→"...")Updated source:
src/core_patterns.mdSynced: All adapter files (SKILL.md, SKILL_PROFESSIONAL.md, 8 adapters)
Example
Before (two patterns):
After (one pattern):
Both issues relate to quotation mark usage and are now consolidated under a single pattern detection.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
PR Type
Enhancement
Description
Consolidated quotation mark patterns into single issue
Added single quote delimiter detection to pattern
Updated all adapter files with consolidated pattern
Reorganized metadata placement in adapter files
Diagram Walkthrough
File Walkthrough
11 files
Consolidate quotation patterns into single issueUpdate pattern 18 with consolidated quotation issuesUpdate pattern 18 with consolidated quotation issuesSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadataSync pattern updates and reorganize metadata