Skip to content

Conversation

Copy link

Copilot AI commented Feb 6, 2026

User description

Addresses feedback from blader#5 that creating a separate pattern for single quotes was verbose.

Changes

Example

Before (two patterns):

### 18. Curly Quotation Marks
Problem: ChatGPT uses curly quotes...

### 19. Primary Single Quotes  
Problem: AI uses single quotes...

After (one pattern):

### 18. Quotation Mark Issues
Problem: AI models make two common quotation mistakes:
1. Using curly quotes ("...") instead of straight quotes ("...")
2. Using single quotes ('...') as primary delimiters

Both issues relate to quotation mark usage and are now consolidated under a single pattern detection.

Original prompt

Address all of the comments raised in the pull request, as well as the comments.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


PR Type

Enhancement


Description

  • Consolidated quotation mark patterns into single issue

  • Added single quote delimiter detection to pattern

  • Updated all adapter files with consolidated pattern

  • Reorganized metadata placement in adapter files


Diagram Walkthrough

flowchart LR
  A["Pattern 18<br/>Curly Quotes"] --> C["Pattern 18<br/>Quotation Mark Issues"]
  B["Pattern 19<br/>Single Quotes"] --> C
  C --> D["Updated<br/>Core Patterns"]
  D --> E["Synced to<br/>10 Adapters"]
Loading

File Walkthrough

Relevant files
Enhancement
11 files
core_patterns.md
Consolidate quotation patterns into single issue                 
+7/-3     
SKILL.md
Update pattern 18 with consolidated quotation issues         
+7/-3     
SKILL_PROFESSIONAL.md
Update pattern 18 with consolidated quotation issues         
+7/-3     
README.md
Sync pattern updates and reorganize metadata                         
+15/-15 
SKILL.md
Sync pattern updates and reorganize metadata                         
+15/-15 
SKILL_PROFESSIONAL.md
Sync pattern updates and reorganize metadata                         
+15/-15 
COPILOT.md
Sync pattern updates and reorganize metadata                         
+15/-15 
GEMINI.md
Sync pattern updates and reorganize metadata                         
+15/-15 
GEMINI_PRO.md
Sync pattern updates and reorganize metadata                         
+15/-15 
QWEN.md
Sync pattern updates and reorganize metadata                         
+15/-15 
HUMANIZER.md
Sync pattern updates and reorganize metadata                         
+15/-15 

Copilot AI changed the title [WIP] Address all comments raised in the pull request Combine quotation mark patterns to reduce verbosity Feb 6, 2026
Copilot AI requested a review from edithatogo February 6, 2026 06:55
@edithatogo edithatogo marked this pull request as ready for review February 6, 2026 09:38
Copilot AI review requested due to automatic review settings February 6, 2026 09:38
@edithatogo edithatogo merged commit 11edc53 into main Feb 6, 2026
0 of 4 checks passed
@edithatogo edithatogo deleted the copilot/address-pr-comments branch February 6, 2026 09:38
@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Consolidate YAML frontmatter at top

Move the adapter_metadata block to the top of the file and merge it into the
existing YAML frontmatter section to ensure it is parsed correctly.

adapters/antigravity-rules-workflows/README.md [34-41]

+---
 adapter_metadata:
   skill_name: humanizer
   skill_version: 2.2.0
   last_synced: 2026-02-06
   source_path: SKILL.md
   adapter_id: antigravity-rules-workflows
   adapter_format: Antigravity rules/workflows
 ---
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies that the PR adds adapter_metadata as a separate, misplaced YAML block, which is invalid. Consolidating it into the main frontmatter at the top of the file is crucial for correct parsing.

Medium
Clarify rule to preserve nested quotes

Clarify the rule for replacing single quotes with double quotes to avoid
incorrectly changing valid nested quotations. Add a note specifying that single
quotes used for nested quotes should be preserved.

src/core_patterns.md [237-239]

 **Problem:** AI models make two common quotation mistakes:
 1. Using curly quotes (“...”) instead of straight quotes ("...")
-2. Using single quotes ('...') as primary delimiters (from code training)
+2. Using single quotes ('...') as primary delimiters. Double quotes are preferred for consistency, but do not change single quotes used for nested quotations (e.g., "He said, 'Let's go.'").
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that the new rule for replacing single quotes is too broad and could cause incorrect changes to valid nested quotes, improving the rule's accuracy.

Low
  • More

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates two related quotation mark detection patterns (curly quotes and single quotes as primary delimiters) into a single "Quotation Mark Issues" pattern to reduce verbosity. The change updates Pattern blader#18 from detecting only curly quotes to detecting both curly quotes and single quotes used as primary delimiters.

Changes:

  • Combined Pattern blader#18 (Curly Quotation Marks) and the proposed Pattern blader#19 (Primary Single Quotes) into a single "Quotation Mark Issues" pattern
  • Updated the last_synced date from 2026-01-31 to 2026-02-06 across adapter files
  • Updated all references to Pattern blader#18 in the SEVERITY CLASSIFICATION sections

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/core_patterns.md Source file updated with combined Pattern blader#18 including both curly and single quote issues
SKILL.md Root skill file updated with combined pattern and updated references
SKILL_PROFESSIONAL.md Professional variant updated with combined pattern and updated references
adapters/vscode/HUMANIZER.md VSCode adapter synced with combined pattern; metadata repositioned
adapters/qwen-cli/QWEN.md Qwen CLI adapter synced with combined pattern; metadata repositioned
adapters/gemini-extension/GEMINI_PRO.md Gemini Pro adapter synced with combined pattern; metadata repositioned
adapters/gemini-extension/GEMINI.md Gemini adapter synced with combined pattern; metadata repositioned
adapters/copilot/COPILOT.md Copilot adapter synced with combined pattern; metadata repositioned
adapters/antigravity-skill/SKILL_PROFESSIONAL.md Antigravity Pro skill synced with combined pattern; metadata repositioned
adapters/antigravity-skill/SKILL.md Antigravity skill synced with combined pattern; metadata repositioned
adapters/antigravity-rules-workflows/README.md Antigravity workflows synced with combined pattern; metadata repositioned

Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: antigravity-rules-workflows
adapter_format: Antigravity rules/workflows
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: vscode
adapter_format: VSCode markdown
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer-pro
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL_PROFESSIONAL.md
adapter_id: gemini-extension-pro
adapter_format: Gemini extension
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: copilot
adapter_format: Copilot instructions
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer-pro
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL_PROFESSIONAL.md
adapter_id: antigravity-skill-pro
adapter_format: Antigravity skill
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +235 to +247
### 18. Quotation Mark Issues

**Problem:** ChatGPT uses curly quotes (“...”) instead of straight quotes ("...").
**Problem:** AI models make two common quotation mistakes:
1. Using curly quotes (“...”) instead of straight quotes ("...")
2. Using single quotes ('...') as primary delimiters (from code training)

**Before:**
> He said “the project is on track” but others disagreed.
> She stated, 'This is the final version.'

**After:**
> He said "the project is on track" but others disagreed.
> She stated, "This is the final version."
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CODEX.md adapter file was not updated to reflect the combined Pattern blader#18 changes. This file still contains the old "Curly Quotation Marks" pattern at line 95 and lacks the new combined "Quotation Mark Issues" pattern that includes both curly quotes and single quote issues. For consistency, this adapter should be updated the same way as the other 8 adapter files in this PR.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: qwen-cli
adapter_format: Qwen CLI context
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: gemini-extension
adapter_format: Gemini extension
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Comment on lines +34 to 41
adapter_metadata:
skill_name: humanizer
skill_version: 2.2.0
last_synced: 2026-02-06
source_path: SKILL.md
adapter_id: antigravity-skill
adapter_format: Antigravity skill
---
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter_metadata block has been moved from the top of the YAML front matter (before the "name" field) to inside the document content (after item blader#5 of the task list, before the closing "---"). This breaks the YAML structure as adapter_metadata is now outside the front matter block and appears as plain text rather than structured metadata. The metadata should remain within the opening "---" and closing "---" delimiters of the YAML front matter.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants