Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added-graphql-logo #868

Closed
wants to merge 3 commits into from
Closed

Conversation

Karan-Nagure
Copy link

@Karan-Nagure Karan-Nagure commented Oct 26, 2024

I have taken care of each and every constraints. I have added the logo of GraphQL. Issue no. #828

@edent
Copy link
Owner

edent commented Oct 26, 2024

Do you think this looks right?

image

Would you like to try and fix it, or shall I just apply the Hacktoberfest spam label now?

@Karan-Nagure
Copy link
Author

Sir, please check out the changes I have did in the 2nd commit. I have uploaded the correct svg file now. Please do check and merge it if it is correct.
Screenshot 2024-10-27 122014

@edent
Copy link
Owner

edent commented Oct 27, 2024

Did you read https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md ?

Do you think this complies with the information in there?

@Karan-Nagure
Copy link
Author

Yes, I think everything is okay except creating a android version

@edent edent added the spam label Oct 27, 2024
@edent
Copy link
Owner

edent commented Oct 27, 2024

Your logo is over 1,024 bytes. It doesn't look like the others. You've added the R logo into the root. For some reason, you've also added an HTML5 logo.

I don't know if you're trying to complete Hacktoberfest - but this isn't the way to do it.

Don't just add loads of AI generated stuff you don't understand. Read the guidelines. Ask questions. Start small.

@edent edent closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants