Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add if_left_fn and if_right_fn #42

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

edeckers
Copy link
Owner

@edeckers edeckers commented Jan 9, 2025

This PR adds if_left_fn and if_right_fn convenience functions to Either as proposed by @drupol in #41.

Copy link

github-actions bot commented Jan 9, 2025

Test Results

34 tests  +4   34 ✅ +4   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 17fd16e. ± Comparison against base commit 2527651.

Copy link

github-actions bot commented Jan 9, 2025

Test Results

34 tests  +4   34 ✅ +4   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7307e30. ± Comparison against base commit 3eed99f.

♻️ This comment has been updated with latest results.

@edeckers edeckers force-pushed the elydeckers/feat/add-callable-if-left-and-if-right branch from 17fd16e to 4152832 Compare January 9, 2025 13:10
@edeckers edeckers force-pushed the elydeckers/feat/add-callable-if-left-and-if-right branch from 5e7d84a to 7307e30 Compare January 9, 2025 13:51
@edeckers edeckers marked this pull request as ready for review January 9, 2025 13:53
@edeckers edeckers changed the title feat: add callable if left and if right feat: add if_left_fn and if_right_fn Jan 9, 2025
@edeckers
Copy link
Owner Author

edeckers commented Jan 9, 2025

Does this solve #41 for you @drupol? I'm on board adding this, even though it kind of violates my wish of sticking with the Haskell API; seems like a useful feature that was missing.

@drupol
Copy link

drupol commented Jan 9, 2025

I'm all for it :) THANK YOU !

@edeckers edeckers merged commit 95a4efa into develop Jan 9, 2025
4 checks passed
@edeckers edeckers deleted the elydeckers/feat/add-callable-if-left-and-if-right branch January 9, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants