Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump appsignal from 4.2.3 to 4.3.1 #750

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 20, 2024

Bumps appsignal from 4.2.3 to 4.3.1.

Changelog

Sourced from appsignal's changelog.

4.3.1

Published on 2024-12-20.

Fixed

  • Fix a performance issue when sanitising INSERT INTO ... VALUES queries. (patch 9791d9a1)

4.3.0

Published on 2024-12-20.

Added

  • Add logger broadcasting. This change implements an alternative within Appsignal::Logger to ActiveSupport::BroadcastLogger, following the same interface. This enables a proper workaround to the issues with ActiveSupport::BroadcastLogger ((#49745, #51883)) when used alongside tagged logging.

    For example, to use tagged logging both in logs emitted by the default Rails.logger and in logs sent to AppSignal, replace the Rails.logger with an AppSignal logger that broadcasts to the default Rails.logger:

    appsignal_logger = Appsignal::Logger.new("app")
    appsignal_logger.broadcast_to(Rails.logger)
    Rails.logger = ActiveSupport::TaggedLogging.new(appsignal_logger)

    (minor 5cb1464b)

Removed

  • Remove tagged logging support from Appsignal::Logger.

    Tagged logging is still supported by wrapping an instance of Appsignal::Logger with ActiveSupport::TaggedLogging:

    appsignal_logger = Appsignal::Logger.new("rails")
    tagged_logger = ActiveSupport::TaggedLogging.new(appsignal_logger)
    Rails.logger = tagged_logger

    Removing this functionality allows for a workaround to issues within Rails (#49745, #51883), where using the broadcast logger to log to more than one tagged logger results in incorrect behaviour of the tagged logging methods, resulting in breakage throughout Rails' internals:

    # We use the built-in request ID middleware as an example that triggers
    # the issue:
    Rails.config.log_tags = [:request_id]
    appsignal_logger = Appsignal::Logger.new("rails")
    tagged_logger = ActiveSupport::TaggedLogging.new(appsignal_logger)
    This does not work correctly, because the default Rails.logger is a
    broadcast logger that is already broadcasting to a tagged logger.

... (truncated)

Commits
  • e23c26f Publish package v4.3.1
  • 6a3f685 Merge pull request #1358 from appsignal/update-agent/0.35.29
  • 9791d9a Update agent to version 0.35.29
  • 34bb293 Publish package v4.3.0
  • a77a218 Merge pull request #1357 from appsignal/implement-logger-broadcasting
  • 5cb1464 Implement logger broadcasting
  • 25a0323 Merge pull request #1356 from appsignal/implement-silence-logger-functionality
  • c610a0c Merge pull request #1355 from appsignal/remove-tagged-logging-support
  • d08a1ce Implement #silence logger functionality
  • 2468e74 Pass the logger to #silence block
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [appsignal](https://github.com/appsignal/appsignal-ruby) from 4.2.3 to 4.3.1.
- [Changelog](https://github.com/appsignal/appsignal-ruby/blob/main/CHANGELOG.md)
- [Commits](appsignal/appsignal-ruby@v4.2.3...v4.3.1)

---
updated-dependencies:
- dependency-name: appsignal
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 20, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 24, 2024

Looks like appsignal is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Dec 24, 2024
@dependabot dependabot bot deleted the dependabot/bundler/appsignal-4.3.1 branch December 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants