Skip to content

[15.0][FIX] budget_control_expense: check_over_returned_budget only ml debit #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pani-k-folk wants to merge 2 commits into from
Closed

[15.0][FIX] budget_control_expense: check_over_returned_budget only ml debit #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4abfc71
[FIX] budget_control_expene: check_over_returned_budget only ml debit…
Pani-k-folk Feb 12, 2026
0a09a1b
[FIX] budget_control_expense: uncommit only ml expense account
Pani-k-folk Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion budget_control_expense/models/account_move_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,15 @@ def uncommit_expense_budget(self):
"""Uncommit the budget for related expenses when the vendor bill is in a valid state."""
Expense = self.env["hr.expense"]
for ml in self:
account = ml.account_id
inv_state = ml.move_id.state
move_type = ml.move_id.move_type
if move_type != "entry":
continue
if inv_state == "posted":
expense = ml.expense_id.filtered("amount_commit")
# Because this is not invoice, we need to compare account
if not expense:
if not expense or expense.account_id != account:
continue
# Also test for future advance extension, never uncommit for advance
if hasattr(expense, "advance") and expense["advance"]:
Expand Down
Loading