Skip to content

fix(graphic/Image):修复图片未加载时获取尺寸不正确的问题 #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(graphic/Image):修复图片未加载时获取尺寸不正确的问题 #1141

wants to merge 1 commit into from

Conversation

@lirencai
Copy link

当图片尚未加载完成时，确保下次能获取到正确的尺寸值。通过在检测到图片未就绪时将 _rect 设为 null，从而触发重新计算。

@lirencai
fix(graphic/Image):修复图片未加载时获取尺寸不正确的问题
284d078 
当图片尚未加载完成时，确保下次能获取到正确的尺寸值。通过在检测到图片未就绪时将 _rect 设为 null，从而触发重新计算。
Ovilia
Ovilia reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具体的使用场景是什么样的？getBoundingRect 返回 null 可能是一种未定义的行为，请问哪里的逻辑保证了返回 null 会重新计算？可能更好的解决方案是，在外部使用的时候，判断图片是否完成了加载，而不是在内部做这个修改。

@Jancheng-z
Copy link

Jancheng-z commented Oct 9, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ovilia Ovilia Ovilia left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lirencai @Jancheng-z @Ovilia