Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace-tag-attribute 在特定情况下不符合预期 #104

Open
firede opened this issue Oct 21, 2015 · 1 comment
Open

replace-tag-attribute 在特定情况下不符合预期 #104

firede opened this issue Oct 21, 2015 · 1 comment
Labels
bug

Comments

@firede
Copy link
Member

firede commented Oct 21, 2015

传送门：https://github.com/ecomfe/edp-build/blob/master/lib/util/replace-tag-attribute.js

1. attribute 中包含 < 时出错

如 <head><script src="<$root>/path/file.js" type="text/javascript"></script></head> 中的 <$root> 变量，会导致解析出错。

2. 会匹配到所有以 tag 名为前缀的标签

如搜索 menu 标签时，若有 menubar 的标签，也会被错误的匹配到。
@firede firede added the bug label Oct 21, 2015
firede added a commit that referenced this issue Oct 21, 2015
@firede
issue #104. add test case && bugfix.
2186261
@firede
Copy link
Member Author

firede commented Oct 21, 2015

bug 1 已修，bug 2 需要去找找有没有误用的状况再修。

leeight pushed a commit that referenced this issue Jul 28, 2016
@firede @leeight
issue #104. add test case && bugfix.
dea822a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@firede