issue #104. add test case && bugfix.

firede · firede · commit 2186261d4bef · 2015-10-21T17:49:10.000+08:00
diff --git a/lib/util/replace-tag-attribute.js b/lib/util/replace-tag-attribute.js
@@ -28,7 +28,7 @@
  */
 module.exports = exports = function (content, tag, attribute, valueReplacer, condition) {
     var attrReg = new RegExp('(' + attribute + ')=([\'"])([^\'"]+)\\2');
-    var tagReg = new RegExp('<' + tag + '([^>]+)', 'g');
+    var tagReg = new RegExp('<' + tag + '(("[^"]*"|\'[^\']*\'|[^\'">])*)', 'g');
     function replacer(match, attrStr) {
         if (typeof condition === 'function' && !condition(match.slice(1))) {
             return match;
diff --git a/test/replace-tag-attribute.spec.js b/test/replace-tag-attribute.spec.js
@@ -0,0 +1,55 @@
+/**
+ * @file 测试一下 replace-tag-attribute 功能是否正常
+ * @author Firede(firede@firede.us)
+ */
+
+var replaceTagAttribute = require('../lib/util/replace-tag-attribute');
+
+describe('replace-tag-attribute', function () {
+
+    var expectValue = '<head><script src="/root/path/file.js" type="text/javascript"></script></head>';
+
+    it('default', function () {
+        var value = replaceTagAttribute(
+            '<head><script src="${root}/path/file.js" type="text/javascript"></script></head>',
+            'script',
+            'src',
+            function (val) {
+                return val.replace('${root}', '/root');
+            }
+        );
+
+        expect(value).toBe(expectValue);
+    });
+
+    it('attribute value include `<`', function () {
+        var value = replaceTagAttribute(
+            '<head><script src="<$root>/path/file.js" type="text/javascript"></script></head>',
+            'script',
+            'src',
+            function (val) {
+                return val.replace('<$root>', '/root');
+            }
+        );
+        
+        expect(value).toBe(expectValue);
+    });
+
+    it('script-x should not matched', function () {
+        // FIXME 这个 case 暂时还通不过
+        // 当搜索 tag 为 script 时，会匹配到以 script 为前缀的所有 tag
+        // 要先确定当前有没有误用的情况，再修复此问题
+        var textScriptX = '<head><script-x src="${root}/path/file.js" type="text/javascript"></script></head>';
+        var value = replaceTagAttribute(
+            textScriptX,
+            'script',
+            'src',
+            function (val) {
+                return val.replace('${root}', '/root');
+            }
+        );
+        console.log(value);
+        expect(value).toBe(textScriptX);
+    });
+
+});
