feat: 添加 MultipleBytes 实现多协程安全读写 #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flycash
reviewed
Jan 21, 2025
iox/multiple_bytes.go
Outdated
Comment on lines
98
to
110
| func (m *MultipleBytes) Len() int { | ||
| m.mutex.RLock() | ||
| defer m.mutex.RUnlock() | ||
|
|
||
| total := 0 | ||
| for _, slice := range m.data { | ||
| total += len(slice) | ||
| } | ||
| return total | ||
| } | ||
|
|
||
| // Cap 返回当前缓冲区的容量 | ||
| func (m *MultipleBytes) Cap() int { |
There was a problem hiding this comment.
这两个方法先不需要实现，因为目前来看没什么使用场景，而且 Cap 没有啥意义，因为是允许扩容的
iox/multiple_bytes.go
Outdated
| } | ||
|
|
||
| // Bytes 返回内部缓冲区的副本 | ||
| func (m *MultipleBytes) Bytes() []byte { |
iox/multiple_bytes.go
Outdated
| } | ||
|
|
||
| // Clear 清空缓冲区并重置读取位置 | ||
| func (m *MultipleBytes) Clear() { |
iox/multiple_bytes_test.go
Outdated
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestMultipleBytes_ReadWrite(t *testing.T) { |
There was a problem hiding this comment.
Write 测试用例比较简单，但是 Read 需要更加复杂的测试用例
There was a problem hiding this comment.
Read 要考虑更加多的边缘场景，包括但不限于：
- 只有一个 slice，读够了，没读够；
- 多个 slice，读数据横跨了多个 slice 才读够、恰好读够，没读够；
- idx1 和 idx2 指向第一个、最好一个的交叉验证；
flycash
reviewed
Jan 22, 2025
iox/multiple_bytes.go
Outdated
| return 0, nil | ||
| } | ||
|
|
||
| // 创建新的切片来存储数据 |
There was a problem hiding this comment.
不需要，我们就是为了规避 copy 而引入的，所以这里不要 copy，直接 append
| // 读取数据 | ||
| for i, size := range tc.readSizes { | ||
| read := make([]byte, size) | ||
| n, err := mb.Read(read) |
| } | ||
|
|
||
| // 测试基本的并发读写功能 | ||
| func TestConcurrentMultipleBytesConcurrentReadWrite(t *testing.T) { |
There was a problem hiding this comment.
这个不需要重复测试，因为本身你可以认为非线程安全的版本已经保证这一段是正确的了，所以实际上你只需要随便写一点测试就可以。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.